Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to cover Helm install of Pepr #1514

Closed
btlghrants opened this issue Dec 5, 2024 · 0 comments
Closed

Add test to cover Helm install of Pepr #1514

btlghrants opened this issue Dec 5, 2024 · 0 comments
Assignees
@btlghrants
Labels
Testing Testing
Milestone
v0.42.0

Comments

@btlghrants
Copy link
Contributor

It came up in conversation yesterday -- after a refactor of the logic with which we generate the Pepr helm chart -- that we do not (yet) exercise the resulting chart in CI.

This issue is a request to rectify that.
@btlghrants btlghrants self-assigned this Dec 5, 2024
@btlghrants btlghrants converted this from a draft issue Dec 5, 2024
@btlghrants btlghrants added the Testing Testing label Dec 5, 2024
@btlghrants btlghrants added this to the v0.41.0 milestone Dec 5, 2024
@btlghrants btlghrants changed the title Add test to cover Helm installing Pepr Add test to cover Helm install of Pepr Dec 5, 2024
@cmwylie19 cmwylie19 mentioned this issue Dec 5, 2024
Closed
@btlghrants btlghrants mentioned this issue Dec 5, 2024
Merged
5 tasks
@btlghrants btlghrants moved this from 🏗 In progress to 👀 In review in Pepr Project Board Dec 5, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 5, 2024
@btlghrants
test: validate pepr build generates a helm install-able chart (#1520
244747d 
)

## Description

Adds workflow to validate that deploying a Pepr Module via `helm
install` works.

## Related Issue
Relates to #1514 

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging
- [x] Unit,
[Journey](https://github.com/defenseunicorns/pepr/tree/main/journey),
[E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples),
[docs](https://github.com/defenseunicorns/pepr/tree/main/docs),
[adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or
updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed
@samayer12 samayer12 mentioned this issue Dec 5, 2024
Closed
@btlghrants btlghrants moved this from 👀 In review to ✅ Done in Pepr Project Board Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@btlghrants btlghrants

Labels
Testing Testing
Projects
Pepr Project Board
Archived in project
Milestone
v0.42.0
Development

No branches or pull requests
1 participant
@btlghrants