Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complexity of mutate-processor #1532

Closed
cmwylie19 opened this issue Dec 6, 2024 · 0 comments · Fixed by #1543
Closed

Complexity of mutate-processor #1532

cmwylie19 opened this issue Dec 6, 2024 · 0 comments · Fixed by #1543
Assignees
@btlghrants
Labels
complexity complexity tech-debt
Milestone
v0.42.2

Comments

@cmwylie19
Copy link
Contributor

cmwylie19 commented Dec 6, 2024 •
edited
Loading

Describe what should be investigated or refactored

  17:8   warning  Async function 'mutateProcessor' has a complexity of 18. Maximum allowed is 10        complexity
@cmwylie19 cmwylie19 added this to the v0.43.0 milestone Dec 6, 2024
@btlghrants btlghrants self-assigned this Dec 9, 2024
@btlghrants btlghrants moved this from 🆕 New to 🏗 In progress in Pepr Project Board Dec 9, 2024
@btlghrants btlghrants added the complexity complexity label Dec 9, 2024
@btlghrants btlghrants mentioned this issue Dec 9, 2024
Merged
@btlghrants btlghrants moved this from 🏗 In progress to 👀 In review in Pepr Project Board Dec 12, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 12, 2024
@btlghrants
refactor: resolve eslint warnings (max-depth, complexity) - src/lib/m…
6729370 
…utate-processor.ts (#1543)

### Describe what should be investigated or refactored

Refactor of `src/lib/mutate-processor.ts` to reduce complexity warnings:
```
/pepr/src/lib/mutate-processor.ts
  18:8  warning  Async function 'mutateProcessor' has a complexity of 18. Maximum allowed is 10        complexity
  18:8  warning  Async function 'mutateProcessor' has too many statements (49). Maximum allowed is 20  max-statements
  99:9  warning  Blocks are nested too deeply (4). Maximum allowed is 3                                max-depth
```

### Additional context
Fixes #1532 
In support of #1248
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Pepr Project Board Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@btlghrants btlghrants

Labels
complexity complexity tech-debt
Projects
Pepr Project Board
Archived in project
Milestone
v0.42.2
2 participants
@cmwylie19 @btlghrants