Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardized readiness-checks for Helm & Zarf CI tests #1540

Closed
samayer12 opened this issue Dec 6, 2024 · 0 comments · Fixed by #1541
Closed

Standardized readiness-checks for Helm & Zarf CI tests #1540

samayer12 opened this issue Dec 6, 2024 · 0 comments · Fixed by #1541
Labels
github_actions Pull requests that update GitHub Actions code tech-debt

Comments

@samayer12
Copy link
Contributor

Describe what should be investigated or refactored

#1531 and #1520 verified that pepr is deployable with Zarf & Helm. In the end, the same type of readiness check is used for both types of install methods.
We should use the readiness check presented in check-deployment-readiness.sh for both tests.

Links to any relevant code

  • deploy-zarf.yml
  • deploy-helm.yml
  • check-deployment-readiness.sh

Additional context

Test success is defined by all the replicas for pepr & the pepr watcher being ready
@samayer12 samayer12 added github_actions Pull requests that update GitHub Actions code tech-debt labels Dec 6, 2024
@samayer12 samayer12 mentioned this issue Dec 6, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Dec 9, 2024
@samayer12
chore(ci): use standard check for helm & zarf installs (#1541)
9d5beb1 
## Description

Use the same deployment checks to confirm success with helm & zarf.

## Related Issue

Fixes #1540

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging
- [x] Unit,
[Journey](https://github.com/defenseunicorns/pepr/tree/main/journey),
[E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples),
[docs](https://github.com/defenseunicorns/pepr/tree/main/docs),
[adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or
updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ci): use standard check for helm & zarf installs defenseunicorns/pepr
1 participant
@samayer12