Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return types on yaml.ts webhooks.ts, pods.ts, helm.ts and destroy.ts #1551

Closed
cmwylie19 opened this issue Dec 9, 2024 · 0 comments · Fixed by #1560
Closed

return types on yaml.ts webhooks.ts, pods.ts, helm.ts and destroy.ts #1551

cmwylie19 opened this issue Dec 9, 2024 · 0 comments · Fixed by #1560
Assignees
@samayer12
Labels
tech-debt
Milestone
v0.42.2

Comments

@cmwylie19
Copy link
Contributor

Describe what should be investigated or refactored

Turn on eslint settings to keep codebase clean, maintainable and standardized.
@cmwylie19 cmwylie19 moved this from 🆕 New to 📋 Backlog in Pepr Project Board Dec 9, 2024
@cmwylie19 cmwylie19 added this to the v0.43.0 milestone Dec 9, 2024
@samayer12 samayer12 self-assigned this Dec 10, 2024
@samayer12 samayer12 mentioned this issue Dec 10, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Dec 11, 2024
@samayer12
chore: add return types to untyped functions (#1560)
a7989f7 
## Description

Adds typing to untyped functions

End to End Test:  <!-- if applicable -->  
(See [Pepr Excellent
Examples](https://github.com/defenseunicorns/pepr-excellent-examples))

## Related Issue

Fixes #1551

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging
- [x] Unit,
[Journey](https://github.com/defenseunicorns/pepr/tree/main/journey),
[E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples),
[docs](https://github.com/defenseunicorns/pepr/tree/main/docs),
[adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or
updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Pepr Project Board Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samayer12 samayer12

Labels
tech-debt
Projects
Pepr Project Board
Archived in project
Milestone
v0.42.2
Development

Successfully merging a pull request may close this issue.

chore: add return types to untyped functions defenseunicorns/pepr
2 participants
@cmwylie19 @samayer12