Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix circular dependency between lib.ts and sdk.ts #1348

Merged
merged 10 commits into from
Oct 30, 2024

Conversation

schaeferka
Copy link
Contributor

@schaeferka schaeferka commented Oct 29, 2024

Description

There is a circular dependency between lib.ts and sdk.ts that should be fixed.

In addition, the duplicate code related to types.ts and mutate-types.ts needs to be resolved.
...

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Fixes #1349

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@schaeferka schaeferka self-assigned this Oct 29, 2024
@schaeferka schaeferka requested a review from a team as a code owner October 29, 2024 17:32
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.35%. Comparing base (58633b8) to head (4b41963).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1348      +/-   ##
==========================================
- Coverage   79.36%   79.35%   -0.02%     
==========================================
  Files          38       37       -1     
  Lines        1793     1792       -1     
  Branches      363      363              
==========================================
- Hits         1423     1422       -1     
  Misses        368      368              
  Partials        2        2              
Files with missing lines Coverage Δ
src/lib/capability.ts 94.90% <100.00%> (ø)
src/lib/enums.ts 100.00% <100.00%> (ø)
src/lib/filter/adjudicators.ts 100.00% <100.00%> (ø)
src/lib/filter/filtersWithLogs.ts 98.83% <100.00%> (ø)
src/lib/finalizer.ts 100.00% <100.00%> (ø)
src/lib/mutate-request.ts 100.00% <100.00%> (ø)
src/lib/validate-request.ts 100.00% <100.00%> (ø)
src/lib/watch-processor.ts 79.20% <100.00%> (ø)
src/sdk/sdk.ts 100.00% <ø> (ø)

@schaeferka schaeferka marked this pull request as draft October 29, 2024 17:37
@schaeferka schaeferka marked this pull request as ready for review October 29, 2024 17:49
src/lib/types.ts Outdated Show resolved Hide resolved
@schaeferka schaeferka requested a review from cmwylie19 October 29, 2024 20:37
@cmwylie19 cmwylie19 merged commit 68c1cab into main Oct 30, 2024
47 of 48 checks passed
@cmwylie19 cmwylie19 deleted the types-circular-fix branch October 30, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

chore: fix circular dependencies between lib.ts and sdk.ts
2 participants