Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test cleanup of unneeded folders #1449

Merged
merged 3 commits into from
Nov 20, 2024
Merged

chore: test cleanup of unneeded folders #1449

merged 3 commits into from
Nov 20, 2024

Conversation

cmwylie19
Copy link
Collaborator

Description

When running npm test the pepr-test-module is created with journey tests are run on module. This is a common place to test new features in the controller. However, there was legacy folders being left in the dist folder after the test ended. This PR cleans up the legacy folders that are no longer needed after the test ends and not relevant for controller testing.

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Fixes #1361

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@cmwylie19 cmwylie19 requested a review from a team as a code owner November 20, 2024 14:02
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.55%. Comparing base (feff8ee) to head (78f8ea0).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1449   +/-   ##
=======================================
  Coverage   78.55%   78.55%           
=======================================
  Files          36       36           
  Lines        1716     1716           
  Branches      410      410           
=======================================
  Hits         1348     1348           
- Misses        339      366   +27     
+ Partials       29        2   -27     

see 7 files with indirect coverage changes

---- 🚨 Try these New Features:

@cmwylie19 cmwylie19 enabled auto-merge (squash) November 20, 2024 14:21
Signed-off-by: Case Wylie <[email protected]>
Copy link
Collaborator

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yerp.

@cmwylie19 cmwylie19 merged commit 5d85820 into main Nov 20, 2024
46 checks passed
@cmwylie19 cmwylie19 deleted the 1361 branch November 20, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up journey test for build
2 participants