Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move filesystem operations to new file #1482

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Conversation

samayer12
Copy link
Collaborator

Description

This PR moves a helper function to a dedicated file (filename open to discussion). This change was planned as part of #1402, we can bring it in here to reduce the amount of changes we consider at any given time.

Related Issue

Relates to #1397

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@samayer12 samayer12 requested a review from a team as a code owner November 22, 2024 16:56
@samayer12 samayer12 changed the title Move filesystem operations to new file chore: move filesystem operations to new file Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.56%. Comparing base (adf7c37) to head (77c8b33).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1482   +/-   ##
=======================================
  Coverage   78.56%   78.56%           
=======================================
  Files          37       38    +1     
  Lines        1717     1717           
  Branches      410      410           
=======================================
  Hits         1349     1349           
  Misses        339      339           
  Partials       29       29           
Files with missing lines Coverage Δ
src/lib/filesystemService.ts 100.00% <100.00%> (ø)
src/lib/helpers.ts 97.95% <ø> (-0.11%) ⬇️
---- 🚨 Try these New Features:

@cmwylie19 cmwylie19 added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit a936a1c Nov 22, 2024
46 checks passed
@cmwylie19 cmwylie19 deleted the 1397-split-fs-helpers branch November 22, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants