Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: return types for logger,tls,validate-request #1588

Merged
merged 5 commits into from
Dec 17, 2024
Merged

chore: return types for logger,tls,validate-request #1588

merged 5 commits into from
Dec 17, 2024

Conversation

cmwylie19
Copy link
Collaborator

Description

Related Issue

Fixes #1547

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@cmwylie19 cmwylie19 requested a review from a team as a code owner December 16, 2024 19:51
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.09%. Comparing base (9aa2930) to head (3e33b32).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/telemetry/logger.ts 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1588      +/-   ##
==========================================
- Coverage   81.13%   81.09%   -0.04%     
==========================================
  Files          41       41              
  Lines        1945     1947       +2     
  Branches      428      430       +2     
==========================================
+ Hits         1578     1579       +1     
- Misses        339      340       +1     
  Partials       28       28              
Files with missing lines Coverage Δ
src/lib/tls.ts 100.00% <100.00%> (ø)
src/lib/validate-request.ts 100.00% <100.00%> (ø)
src/lib/telemetry/logger.ts 96.87% <66.66%> (-3.13%) ⬇️

@samayer12 samayer12 enabled auto-merge December 17, 2024 17:01
@samayer12 samayer12 added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 73831e0 Dec 17, 2024
48 checks passed
@samayer12 samayer12 deleted the 1547 branch December 17, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

return types on validate-request.ts, tls.ts, logger.ts, and mutate-processor.ts
2 participants