Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pull-back & prep for update of TS (after next pepr release) #1611

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

btlghrants
Copy link
Collaborator

@btlghrants btlghrants commented Dec 20, 2024

Description

This PR expands the versions of typescript that Pepr will accept (by introducing a pattern to it's version specifier) to allow updating our excellent examples module versions after next release of Pepr.

Background

Given how far behind the tip of the typescript release stream we are, a previous PR tried to update it but was unsuccessful because:

  • Pepr declares a specific peerDep version of typescript
  • Pepr-excellent-examples modules declare 1) a prodDep on a pepr release, and 2) a devDep on a specific version of typescript, example: here.

So, after last update we had a situation where:

  • pepr main --> typescript 5.7.2
  • pepr v0.42.1 --> typescript 5.3.3
  • pexex modules --> typescript 5.7.2

That meant that trying to npm install in the excellent examples gave a dependency conflict, specifically between pepr v0.42.1 wanting only [email protected] vs the examples wanting only [email protected].

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@btlghrants btlghrants marked this pull request as ready for review December 20, 2024 16:34
@btlghrants btlghrants requested a review from a team as a code owner December 20, 2024 16:34
Copy link
Collaborator

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, typically we need to use strict versions, but in this case, we need to have a range so that our e2e tests pass. On our next release we will be able to have a strict range again.

@cmwylie19 cmwylie19 enabled auto-merge December 20, 2024 16:35
@cmwylie19 cmwylie19 added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit a7fa6a4 Dec 20, 2024
55 checks passed
@cmwylie19 cmwylie19 deleted the pre-updated-typescript-peer-dep branch December 20, 2024 16:52
@btlghrants btlghrants self-assigned this Dec 20, 2024
@btlghrants btlghrants added this to the v0.42.2 milestone Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.24%. Comparing base (6ba93b7) to head (aa66be7).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1611   +/-   ##
=======================================
  Coverage   81.24%   81.24%           
=======================================
  Files          42       42           
  Lines        1962     1962           
  Branches      424      424           
=======================================
  Hits         1594     1594           
  Misses        340      340           
  Partials       28       28           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants