-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: give best practices around mutations #1672
Conversation
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1672 +/- ##
=======================================
Coverage 79.52% 79.52%
=======================================
Files 48 48
Lines 2090 2090
Branches 461 452 -9
=======================================
Hits 1662 1662
Misses 398 398
Partials 30 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested a couple of links & call-outs the one of the config traps that led to us wanting to add this write-up.
Feel free to move it around / re-write those as you will -- just wanted to be sure we had some actionable links / descriptions of how someone might get themselves into trouble by not validating.
Co-authored-by: Barrett <[email protected]>
Co-authored-by: Barrett <[email protected]>
Co-authored-by: Barrett <[email protected]>
Co-authored-by: Barrett <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good PR on mutations. Used this as the basis for a Pepr tip on 16 Jan 2025.
Co-authored-by: Barrett <[email protected]>
Co-authored-by: Barrett <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems right enough to me.
Description
Provide documentation/education on why it is a best practice to always Validate any Mutations.
Related Issue
Fixes #899
Relates to #
Type of change
Checklist before merging