Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deployments for soak for new image #1689

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

cmwylie19
Copy link
Collaborator

Description

The soak.ci.yaml uses pre-built manifests. When this PR merged we went to a distroless image where node is not in the path on the image. We need to update the args on the deployments.

Job Failure

Related Issue

Fixes #

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@cmwylie19 cmwylie19 requested a review from a team as a code owner January 18, 2025 14:17
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.52%. Comparing base (d4786e0) to head (16d3eda).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1689   +/-   ##
=======================================
  Coverage   79.52%   79.52%           
=======================================
  Files          48       48           
  Lines        2090     2090           
  Branches      460      452    -8     
=======================================
  Hits         1662     1662           
  Misses        398      398           
  Partials       30       30           

Copy link
Collaborator

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right!

@btlghrants btlghrants added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit 0286f93 Jan 21, 2025
48 checks passed
@btlghrants btlghrants deleted the fix-ci-new-deploy-templates branch January 21, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants