Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: max-params warning for src/lib/telemetry/metrics.ts #1735

Merged

Conversation

tamirazrab
Copy link
Contributor

Description

Resolve max-params warning for src/lib/telemetry/metrics.ts
...

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Fixes #1699

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.76%. Comparing base (2e03a46) to head (6e371c0).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1735   +/-   ##
=======================================
  Coverage   79.76%   79.76%           
=======================================
  Files          50       50           
  Lines        2120     2120           
  Branches      431      431           
=======================================
  Hits         1691     1691           
  Misses        427      427           
  Partials        2        2           
Files with missing lines Coverage Δ
src/lib/telemetry/metrics.ts 100.00% <100.00%> (ø)

@cmwylie19 cmwylie19 changed the title Resolve max-params warning for src/lib/telemetry/metrics.ts chore: max-params warning for src/lib/telemetry/metrics.ts Jan 28, 2025
Copy link
Contributor

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you need to run npx pepr format

Copy link
Contributor

@samayer12 samayer12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change, the use of Omit<MetricArgs, "registers"> instead of 3 separate parameters will be useful as we examine typing across the project from a more general level, too.

@cmwylie19 cmwylie19 added this pull request to the merge queue Jan 30, 2025
Merged via the queue into defenseunicorns:main with commit 6e131ce Jan 30, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Resolve max-params warning for src/lib/telemetry/metrics.ts
3 participants