-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: max-params warning for src/lib/telemetry/metrics.ts #1735
chore: max-params warning for src/lib/telemetry/metrics.ts #1735
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1735 +/- ##
=======================================
Coverage 79.76% 79.76%
=======================================
Files 50 50
Lines 2120 2120
Branches 431 431
=======================================
Hits 1691 1691
Misses 427 427
Partials 2 2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like you need to run npx pepr format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change, the use of Omit<MetricArgs, "registers">
instead of 3 separate parameters will be useful as we examine typing across the project from a more general level, too.
Description
Resolve max-params warning for src/lib/telemetry/metrics.ts
...
End to End Test:
(See Pepr Excellent Examples)
Related Issue
Fixes #1699
Type of change
Checklist before merging