Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add unit test for webhooks #1744

Merged
merged 2 commits into from
Jan 30, 2025
Merged

chore: add unit test for webhooks #1744

merged 2 commits into from
Jan 30, 2025

Conversation

cmwylie19
Copy link
Contributor

Description

Added coverage to webhooks to ensure correctness of webhook rules, config and values.

Related Issue

Fixes #1656

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Signed-off-by: Case Wylie <[email protected]>
@cmwylie19 cmwylie19 requested a review from a team as a code owner January 29, 2025 22:20
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.32%. Comparing base (6e131ce) to head (256edd9).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1744      +/-   ##
==========================================
+ Coverage   79.76%   81.32%   +1.55%     
==========================================
  Files          50       50              
  Lines        2120     2120              
  Branches      431      453      +22     
==========================================
+ Hits         1691     1724      +33     
+ Misses        427      370      -57     
- Partials        2       26      +24     
Files with missing lines Coverage Δ
src/lib/assets/webhooks.ts 95.91% <100.00%> (+67.34%) ⬆️

... and 7 files with indirect coverage changes

@cmwylie19 cmwylie19 marked this pull request as draft January 29, 2025 22:38
@cmwylie19 cmwylie19 marked this pull request as ready for review January 30, 2025 13:13
Copy link
Contributor

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And then there were some where there used to be none! Huzzah!

@btlghrants btlghrants added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit ea4f52d Jan 30, 2025
48 checks passed
@btlghrants btlghrants deleted the 1656 branch January 30, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Increase test coverage in src/lib/assets/webhooks.ts
3 participants