-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix typo dom intellisense discussion #318
Conversation
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
After chatting with @btlghrants we have decided to explain in the docs how to enable WebAssembly by adding it to the This should address @jeff-mccoy 's point about exploding the intellisense by warning the user that by adding WebAssembly support they are bringing in DOM types and the intellisense will grow. This leaves the initial default case free of DOM, while allowing the advanced user can still use use WASM if needed. |
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks gud.
Description
The WebAssembly function is called
concats
, notpeprWASM
. I changed the name of the function to describe what it does and format to update the docs.Additionally, this addresses comments regarding the verbosity in the intellisense while enabling WebAssembly
Related Issue
Fixes #
Relates to #
Type of change
Checklist before merging