Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo dom intellisense discussion #318

Merged
merged 12 commits into from
Oct 19, 2023
Merged

docs: fix typo dom intellisense discussion #318

merged 12 commits into from
Oct 19, 2023

Conversation

cmwylie19
Copy link
Contributor

@cmwylie19 cmwylie19 commented Oct 13, 2023

Description

The WebAssembly function is called concats, not peprWASM. I changed the name of the function to describe what it does and format to update the docs.

Additionally, this addresses comments regarding the verbosity in the intellisense while enabling WebAssembly

Related Issue

Fixes #

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Signed-off-by: Case Wylie <[email protected]>
@cmwylie19 cmwylie19 changed the title docs: fix typo docs: fix typo dom intellisense discussion Oct 16, 2023
@cmwylie19
Copy link
Contributor Author

After chatting with @btlghrants we have decided to explain in the docs how to enable WebAssembly by adding it to the tsconfig.

This should address @jeff-mccoy 's point about exploding the intellisense by warning the user that by adding WebAssembly support they are bringing in DOM types and the intellisense will grow.

This leaves the initial default case free of DOM, while allowing the advanced user can still use use WASM if needed.

Copy link
Contributor

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks gud.

@cmwylie19 cmwylie19 merged commit 4199a65 into main Oct 19, 2023
@cmwylie19 cmwylie19 deleted the type_fix branch October 19, 2023 16:15
@cmwylie19 cmwylie19 self-assigned this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants