Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: npm version #378

Merged
merged 6 commits into from
Nov 17, 2023
Merged

docs: npm version #378

merged 6 commits into from
Nov 17, 2023

Conversation

cmwylie19
Copy link
Contributor

@cmwylie19 cmwylie19 commented Nov 16, 2023

Description

While preparing to write release notes for pepr and looking back over the npx pepr build it became painfully obvious that the Pepr cli was not working on my machine. I tried on my VM and it also didn't work. The problem was the npm version 9.x.x.

After upgrading npm pepr worked as expected. This PR adds to the npm version of 10.x to the README.md under prereqs.

  • Additionally adds more around best practice for Watch
  • Small linting fixes

Related Issue

Fixes #

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Signed-off-by: Case Wylie <[email protected]>
Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for pepr-docs canceled.

Name Link
🔨 Latest commit e399653
🔍 Latest deploy log https://app.netlify.com/sites/pepr-docs/deploys/6557ac18d6d9a7000844e35d

Copy link
Contributor

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@btlghrants btlghrants merged commit c59f350 into main Nov 17, 2023
@btlghrants btlghrants deleted the npm_warning branch November 17, 2023 21:29
@cmwylie19 cmwylie19 self-assigned this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants