Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add dockerfile ADD support #161

Closed

Conversation

marshall007
Copy link
Contributor

@marshall007 marshall007 commented Jun 28, 2024

This allow ADD commands in Dockerfiles to be renovated. See screenshot for proof that it is working. Here is the related package PR: defenseunicorns/uds-package-mattermost#99

image

@marshall007 marshall007 changed the title add dockerfile support add dockerfile ADD support Jun 28, 2024
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw the test through gather

@marshall007 marshall007 changed the title add dockerfile ADD support chore: add dockerfile ADD support Jun 28, 2024
marshall007 pushed a commit to defenseunicorns/uds-package-mattermost that referenced this pull request Jul 16, 2024
## Description

This adds an `initContainer` used to sideload mattermost plugins. New
plugins can be added by adding additional `ADD` commands to the included
`Dockerfile`.

## Related Issue

Fixes #7 

Depends on defenseunicorns/uds-common#161 for
renovate changes.

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-package-mattermost/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: zamaz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants