Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(glide): bump golang.org/x/crypto to 77014cf #482

Closed
wants to merge 1 commit into from

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Feb 6, 2017

@mboersma mboersma added this to the v2.12 milestone Feb 6, 2017
@mboersma mboersma self-assigned this Feb 6, 2017
@codecov-io
Copy link

codecov-io commented Feb 6, 2017

Codecov Report

Merging #482 into master will increase coverage by -0.25%.

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
- Coverage   56.02%   55.78%   -0.25%     
==========================================
  Files          29       29              
  Lines        1219     1219              
==========================================
- Hits          683      680       -3     
- Misses        498      501       +3     
  Partials       38       38
Impacted Files Coverage Δ
pkg/sshd/server.go 55% <ø> (-2.23%)
pkg/healthsrv/buckets_lister.go 90% <ø> (+10%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e60183f...57b76c3. Read the comment docs.

@vdice
Copy link
Member

vdice commented Feb 8, 2017

Alas, (as mentioned offline), we still hit a panic: runtime error: slice bounds out of range (i.e. same end result as orig issue) but here is the latest stacktrace in case it gives any clues:

---> ---> ---> panic: runtime error: slice bounds out of range

goroutine 36308 [running]:
panic(0x11856c0, 0xc4200180c0)
	/usr/local/go/src/runtime/panic.go:500 +0x1a1
github.com/deis/builder/vendor/golang.org/x/crypto/ssh.(*dsaPrivateKey).Sign(0xc420028128, 0x1bdc320, 0xc4200156b0, 0xc42019e940, 0x14, 0x20, 0x0, 0x7c0, 0xc42019e940)
	/go/src/github.com/deis/builder/vendor/golang.org/x/crypto/ssh/keys.go:457 +0x3bf
github.com/deis/builder/vendor/golang.org/x/crypto/ssh.signAndMarshal(0x1be5960, 0xc420028128, 0x1bdc320, 0xc4200156b0, 0xc42019e940, 0x14, 0x20, 0x11178a0, 0x10decc3, 0x11b90c0, ...)
	/go/src/github.com/deis/builder/vendor/golang.org/x/crypto/ssh/server.go:160 +0x6d
github.com/deis/builder/vendor/golang.org/x/crypto/ssh.(*dhGroup).Server(0xc4200b5460, 0x7ff0f8e05298, 0xc4205faea0, 0x1bdc320, 0xc4200156b0, 0xc4204cb8c0, 0x1be5960, 0xc420028128, 0x40df84, 0x130eab0, ...)
	/go/src/github.com/deis/builder/vendor/golang.org/x/crypto/ssh/kex.go:188 +0x511
github.com/deis/builder/vendor/golang.org/x/crypto/ssh.(*handshakeTransport).server(0xc4205c7b80, 0x1be5920, 0xc4200b5460, 0xc4205c3780, 0xc4204cb8c0, 0x1, 0x0, 0xc42060c000)
	/go/src/github.com/deis/builder/vendor/golang.org/x/crypto/ssh/handshake.go:598 +0x1db
github.com/deis/builder/vendor/golang.org/x/crypto/ssh.(*handshakeTransport).enterKeyExchange(0xc4205c7b80, 0xc42043d180, 0xd9, 0xd9, 0x100000001, 0xc420021701)
	/go/src/github.com/deis/builder/vendor/golang.org/x/crypto/ssh/handshake.go:563 +0x3aa
github.com/deis/builder/vendor/golang.org/x/crypto/ssh.(*handshakeTransport).kexLoop(0xc4205c7b80)
	/go/src/github.com/deis/builder/vendor/golang.org/x/crypto/ssh/handshake.go:282 +0x1ec
created by github.com/deis/builder/vendor/golang.org/x/crypto/ssh.newServerTransport
	/go/src/github.com/deis/builder/vendor/golang.org/x/crypto/ssh/handshake.go:135 +0x262

@mboersma mboersma closed this Feb 14, 2017
@mboersma mboersma deleted the update-go-crypto-3 branch February 14, 2017 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants