RBAC support #513
Merged
RBAC support #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it. |
|
Jenkins, OK to test |
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
==========================================
- Coverage 56.53% 56.45% -0.09%
==========================================
Files 29 29
Lines 1240 1240
==========================================
- Hits 701 700 -1
- Misses 501 502 +1
Partials 38 38
Continue to review full report at Codecov.
|
|
Jenkins, add to whitelist |
|
Jenkins, add to whitelist. |
With this change deis-builder became available to work in RBAC-only clusters Works with both Kubernetes 1.5 and 1.6 (see templates/_helpers.tmpl for details) Actually tested with 1.5.7 and 1.6.2 Role allows deis-builder: - secrets: create, update and delete - pods: get, list, watch and create - pods/log: get ClusterRole allows deis-builder: - namespaces: list
vdice
approved these changes
May 16, 2017
mboersma
approved these changes
May 25, 2017
vdice
pushed a commit
to deis/workflow
that referenced
this pull request
May 31, 2017
Adds RBAC support for Workflow, see also: - deis/builder#513 - deis/controller#1292 - deis/fluentd#96 - deis/monitor#195 - deis/router#344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change deis-builder became available to work in RBAC-only clusters
Works with both Kubernetes 1.5 and 1.6 (see
templates/_helpers.tmplfor details)Actually tested with 1.5.7 and 1.6.2
Role allows
deis-builder:secrets:create,updateanddeletepods:get,list,watchandcreatepods/log:getClusterRole allows
deis-builder:namespaces:list