ref(*): fix changelog global command #146
Conversation
|
@Joshua-Anderson, @arschles and @krancour are potential reviewers of this pull request based on my analysis of |
vdice
force-pushed
the
fix-changelog-global
branch
from
569db22 to
70d77fc
Compare
| {{end}} | ||
|
|
||
| {{ if (len .Migrations) gt 0 -}} | ||
| ### Migrations |
There was a problem hiding this comment.
Is Migrations the right term for this? Maybe Updated Components or Releases? I just thought it read a bit strangely:
Migrations
- builder v2.5.4 -> v2.5.5
- controller v2.8.0 -> v2.8.1
- postgres v2.2.5 -> v2.2.6
- registry v2.2.3 -> v2.2.4
Fixes
4745179(builder) - charts: Use the common storage secret
There was a problem hiding this comment.
@mboersma yea, perhaps not the ideal term. Either of the alternatives you mentioned sound good -- and also noticing that the header size should probably be bumped down to that of Fixes below.
vdice
force-pushed
the
fix-changelog-global
branch
from
70d77fc to
5ed429a
Compare
| log.Fatal(err.Error()) | ||
| return cli.NewExitError(err.Error(), 2) | ||
| } | ||
| err = toml.Unmarshal(out, &res) |
There was a problem hiding this comment.
this can be one-line'd:
if err := toml.Unmarshal(out, &res); err != nil {
return cli.NewExitError(err.Error(), 3)
}
There was a problem hiding this comment.
Much appreciated! Changed here and in other spots mentioned.
| if err != nil { | ||
| return cli.NewExitError(err.Error(), 2) | ||
| } | ||
| err = json.Unmarshal(out, &mapping) |
There was a problem hiding this comment.
same here, this can be one-line'd
| return | ||
| } | ||
| vals := &changelog.Values{RepoName: repo, OldRelease: componentVersion.ChartVersion, NewRelease: componentVersion.ComponentVersion} | ||
| _, err = changelog.SingleRepoVals(client, vals, componentVersion.ComponentVersion, repo, true) |
There was a problem hiding this comment.
this can be one-line'd as well!
|
comments are non-blocking, feel free to ignore |
To compensate for individual components now following their own release cadences
vdice
force-pushed
the
fix-changelog-global
branch
from
5ed429a to
b17f979
Compare
To compensate for individual components now following their own release cadences.
Notes:
this goes back to the changelog format used in
v2.0.0-v2.3.0Workflow releases such as v2.2.0 (with the addition of alphabetical ordering!) as opposed to the more recent/manually assembled format as seen in the latest v2.8.0 releasesince the
deisrel changelog globalcommand now takes the previous Workflow release'sgenerate_params.toml(for discerning each component's version migration) and as that file does not contain info on theworkflow,workflow-cliandworkflow-e2erepos, we are unable to add changelog entries with the code as it is now. (Would welcome ideas on how to address this, perhaps in a follow-up issue.) Warnings will be printed like:If/when this PR starts to become a merge candidate, I'll create the associated PR in deis/workflow.
TODO: