Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have storage adapter implementation functions return an exported type #89

Closed
arschles opened this issue Jun 21, 2016 · 0 comments
Closed

Have storage adapter implementation functions return an exported type #89

arschles opened this issue Jun 21, 2016 · 0 comments
Assignees
@arschles
Labels
enhancement

Comments

@arschles
Copy link
Member

Functions like redis.NewStorageAdapter (from #88) currently return *adapter, which is not exported and confusing to see in documentation. This issue is for doing one of the following:

  • Refactoring the codebase so that those types of functions can return storage.Adapter without causing an import cycle
  • Making the *adapter exported
  • Another solution that makes the return type for those New* functions exported?

This issue is a continuation of #88 (comment)
@arschles arschles mentioned this issue Jun 21, 2016
Merged
arschles pushed a commit to arschles/deis-logger that referenced this issue Jun 21, 2016
ref(storage,syslogish): make all storage adapter initialization func …
bff3ef8 
…return storage.Adapter

Fixes deis#89
@arschles arschles mentioned this issue Jun 21, 2016
Merged
@arschles arschles self-assigned this Jun 21, 2016
arschles pushed a commit to arschles/deis-logger that referenced this issue Jul 7, 2016
ref(storage,syslogish): make all storage adapter initialization func …
7109615 
…return storage.Adapter

Fixes deis#89

Also flatten all storage adapters and the storage factory into a single storage package
arschles pushed a commit to arschles/deis-logger that referenced this issue Jul 7, 2016
ref(storage,syslogish): make all storage adapter initialization func …
6f8c772 
…return storage.Adapter

Fixes deis#89

Also flatten all storage adapters and the storage factory into a single storage package
arschles added a commit that referenced this issue Jul 7, 2016
@arschles
ref(storage,syslogish): make all storage adapter initialization funcs…
dcd4077 
… return the storage.Adapter interface (#93)

Fixes #89

Also:

- Flatten all storage adapters and the storage factory into a single storage package
- Move the storage adapter factory into a factory subpackage of 'github.com/deis/logger/storage'
  - Eliminates a circular dependency from the storage adapter packages and storage
- Add a 'testredis' build tag to the './storage/redis_adapter_test.go' (which was added in #88), so that a developer can still run 'go test $(glide nv)' without requiring a redis server be up and running
  - 'make test', however, still runs tests with that tag enabled, because it also runs a redis server in a linked container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arschles arschles

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arschles