Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(boto): specify the region while getting s3 connection #170

Merged
merged 1 commit into from
Nov 29, 2016

Conversation

kmala
Copy link
Contributor

@kmala kmala commented Nov 29, 2016

boto ignores the region as env var.

@deis-bot
Copy link

@bacongobbler and @paulczar are potential reviewers of this pull request based on my analysis of git blame information. Thanks @kmala!

@kmala kmala self-assigned this Nov 29, 2016
@vdice vdice added the LGTM1 label Nov 29, 2016
@mboersma mboersma added this to the v2.9 milestone Nov 29, 2016
@bacongobbler
Copy link
Member

Good catch. Boto3 respects AWS_REGION; Boto2 does not.

@kmala kmala merged commit 6fb2999 into deis:master Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants