feat(ci): send emails to slack on e2e failure #133
Conversation
|
@vdice is a potential reviewer of this pull request based on my analysis of |
Joshua-Anderson
force-pushed
the
jenkins-emails
branch
4 times, most recently
from
726070e to
67d527b
Compare
Joshua-Anderson
force-pushed
the
jenkins-emails
branch
4 times, most recently
from
0020ffa to
fed8617
Compare
|
This is ready for reviews! Here is an example message. |
Joshua-Anderson
force-pushed
the
jenkins-emails
branch
from
fed8617 to
5805b59
Compare
Joshua-Anderson
changed the title
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| // Set a custom user agent | ||
| c.UserAgent = UserAgent |
There was a problem hiding this comment.
@Joshua-Anderson didn't you make this change in another PR (in a different repo)?
There was a problem hiding this comment.
Sorry, that commit accidentally got caught in this PR 😦. I didn't fix it cause the PR it comes from (#123) was about to land but forgot that it was still caught in endless CI.
There was a problem hiding this comment.
got it. ok, I'm fine with both being in at once. can you make sure to add a short description regarding what this does (something like "prevent a panic if there's no user agent" iirc) in the final commit to master?
There was a problem hiding this comment.
I'm not going to merge the first commit in this PR. I'll merge #123 and then rebase to clean up history.
There was a problem hiding this comment.
got it. I was unclear that you were removing the first commit. carry on
if e2e fails, per deis/workflow-cli#133
if e2e fails, per deis/workflow-cli#133
if e2e fails, per deis/workflow-cli#133
Joshua-Anderson
force-pushed
the
jenkins-emails
branch
from
5805b59 to
527eceb
Compare
Joshua-Anderson
force-pushed
the
jenkins-emails
branch
from
527eceb to
711700b
Compare
Joshua-Anderson
force-pushed
the
jenkins-emails
branch
from
711700b to
a961c25
Compare
if e2e fails, per deis/workflow-cli#133
No description provided.