Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): add codecov #146

Merged
merged 1 commit into from
Jul 28, 2016
Merged

feat(ci): add codecov #146

merged 1 commit into from
Jul 28, 2016

Conversation

Joshua-Anderson
Copy link
Contributor

No description provided.

@Joshua-Anderson Joshua-Anderson added this to the v2.3 milestone Jul 21, 2016
@Joshua-Anderson Joshua-Anderson self-assigned this Jul 21, 2016
@deis-bot
Copy link

@vdice is a potential reviewer of this pull request based on my analysis of git blame information. Thanks @Joshua-Anderson!

@Joshua-Anderson
Copy link
Contributor Author

@vdice Any idea why Jenkins is having syntax errors on this pull request?

@vdice
Copy link
Member

vdice commented Jul 22, 2016 •
edited
Loading

@Joshua-Anderson hmmm I don't know why it would complain... I'm not aware of the bash <(curl <bash script>) syntax and/or how it differs/compares to the classic curl <bash script> | bash approach... but perhaps try the latter approach?

@Joshua-Anderson Joshua-Anderson force-pushed the codecov branch 3 times, most recently from d0431ed to de0678d Compare July 22, 2016 15:43
bacongobbler
bacongobbler reviewed Jul 25, 2016
View reviewed changes
Makefile
${DEV_ENV_PREFIX_CGO_ENABLED} ${DEV_ENV_IMAGE} sh -c '${GOTEST} $$(glide nv)'

test-cover: test-style
${DEV_ENV_PREFIX_CGO_ENABLED} ${DEV_ENV_IMAGE} test-cover.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this script located?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's inside the docker-go-dev container

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL. Cool!

@Joshua-Anderson
Copy link
Contributor Author

@vdice The script works for me locally and test-cover does successfully generate a coverage support (coverage.txt). However, in CI, codecov says it can't find any coverage files. Any ideas? Could this be related to the file being created with root permissions? If so, why doesn't travis-ci have this problem?

@Joshua-Anderson Joshua-Anderson force-pushed the codecov branch 5 times, most recently from 3e7657b to 678013c Compare July 28, 2016 18:50
@codecov-io
Copy link

codecov-io commented Jul 28, 2016 •
edited
Loading

Current coverage is 5.25% (diff: 100%)

No coverage report found for master at f94b05f.

Powered by Codecov. Last update f94b05f...2035bbe

@Joshua-Anderson
Copy link
Contributor Author

As you can see, the PR works! Ready for reviews!

@vdice vdice added the LGTM1 label Jul 28, 2016
@Joshua-Anderson
Copy link
Contributor Author

This passed e2e but the result wasn't properly logged

@Joshua-Anderson Joshua-Anderson merged commit 1199b9e into deis:master Jul 28, 2016
@Joshua-Anderson Joshua-Anderson deleted the codecov branch July 28, 2016 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Joshua-Anderson Joshua-Anderson

Labels
easy fix LGTM1 LGTM2
Projects
None yet
Milestone
v2.3
Development

Successfully merging this pull request may close these issues.
6 participants
@Joshua-Anderson @deis-bot @vdice @codecov-io @bacongobbler @mboersma