fix(tests): set owner of files created by containers to the local user #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vdice This seems to be failing CI due to permission issues. Any idea what the problem is? |
Joshua-Anderson
force-pushed
the
update-go-dev
branch
2 times, most recently
from
3283bb9 to
1abfb0f
Compare
Joshua-Anderson
changed the title
|
I'm changing strategy here. Instead of trying to create files with jenkins's specific UID and GID, chown the created files to the local user. |
|
I'm going to unset the LGTMs because I completely redid the code. |
Joshua-Anderson
force-pushed
the
update-go-dev
branch
from
1abfb0f to
d589607
Compare
|
file perms looking good on Jenkins (uid/gid of user jenkins used): |
| @@ -6,11 +6,20 @@ def getBasePath = { String filepath -> | |||
| return filepath.substring(0, filename) | |||
| } | |||
|
|
|||
| def make = { String target -> | |||
| try { | |||
There was a problem hiding this comment.
Curious if this could be rewritten/simplified to:
def make = { String target ->
try {
sh "make ${target}"
} catch(error) {
false
}
sh "make fileperms"
}
... or would that last sh invocation not get run?
There was a problem hiding this comment.
false kills the build, so it wouldn't run
|
curiosity note/question; otherwise LGTM |
|
For some reason the status links to pipeline build #7, which failed, but the most recent build is pipeline build #8 which passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes with jenkins failing to delete files when cleaning up.