fix(CI): False doesn't abort build #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vdice is a potential reviewer of this pull request based on my analysis of |
Joshua-Anderson
force-pushed
the
no-retry
branch
from
c480e3c to
c89394e
Compare
Joshua-Anderson
force-pushed
the
no-retry
branch
from
c89394e to
676bc2c
Compare
Current coverage is 5.15% (diff: 100%)@@ master #158 diff @@
========================================
Files 44 44
Lines 3159 3159
Methods 0 0
Messages 0 0
Branches 0 0
========================================
Hits 163 163
Misses 2972 2972
Partials 24 24
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed this behavior earlier with the gcs closure, but it seemed to work otherwise, so I left it elsewhere.
@jchauncey noticed https://ci.deis.io/job/Deis/job/workflow-cli/job/master/69/console, which indicated that e2e tests would restart until the passed, indicating that false was not working.