Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBAC amendments for e2e #358

Closed
vdice opened this issue May 24, 2017 · 3 comments
Closed

RBAC amendments for e2e #358

vdice opened this issue May 24, 2017 · 3 comments

Comments

@vdice
Copy link
Member

vdice commented May 24, 2017

Currently, e2e doesn't run against a Workflow install with RBAC enabled (would need to --set global.use_rbac=true). (See deis/workflow#812 for addition, scheduled for v2.15)

However, if/when we decided to do so, there appear to be the following changes/amendments needed (seen testing locally):

  1. Lines like this one in the tags tests error out with the following:
$ HOME=/root kubectl get nodes -o jsonpath={.items[*].metadata..labels}
error: group map[autoscaling:0xc820321ea0 batch:0xc8203d4070 certificates.k8s.io:0xc8203d40e0 componentconfig:0xc8203d4150 extensions:0xc8203d4230 policy:0xc8203d42a0 :0xc820321c00 apps:0xc820321c70 rbac.authorization.k8s.io:0xc8203d4310 storage.k8s.io:0xc8203d4380 authorization.k8s.io:0xc820321e30 federation:0xc820321730 authentication.k8s.io:0xc820321ce0] is already registered
  1. Same for similar kubectl invocations in the limits tests.

  2. Other?

@vdice
Copy link
Member Author

vdice commented May 30, 2017

Turns out the errors described above were a result of using an older version of k8s (1.4.6) -- PR has been issued to update this version: #361

Will update this issue if anything actually related to RBAC + e2e is found; otherwise will close.

@vdice
Copy link
Member Author

vdice commented May 30, 2017

Interestingly, the only test failure I am reliably seeing now when running against a Workflow install w/ global.use_rbac=true is the user can run a command with lengthy output in that app's environment test which I've actually been trying to amend in #363

@vdice
Copy link
Member Author

vdice commented Jun 1, 2017

Closing for now; I don't see any amendments needed at this time. (error described in #358 (comment) can also be hit on non-RBAC clusters.)

@vdice vdice closed this as completed Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant