fix(glide): use kubeapp interfaces for Kubernetes client operations #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @jackfrancis and @mboersma to be potential reviewers |
arschles
changed the title
added 3 commits
May 18, 2016 13:55
this dependency will be used for mocking the k8s clients in unit tests
All code that requires a Kubernetes client to interact with secrets now
takes in a KubeSecretGetterCreator - an interface that composes
(github.com/arschles/kubeapp/api/secret).{Getter, Creator} - and the
real Kubernetes client is passed down the stack, as it’s an
implementation of that interface.
Tests are still broken as of this commit, fixes forthcoming.
this commit also modifies various structs in the data package to store the secret creator/getter inside the struct, instead of changing the interface definition
pass implementations in prod and test code
|
I'll augment @mention-bot by guessing that @vdice might be interested in this PR as well 😄 |
| } | ||
| deisSecrets := kubeClient.Secrets(deisNamespace) | ||
| secret, err := deisSecrets.Get(wfmSecretName) | ||
| // deisSecrets := kubeClient.Secrets(deisNamespace) |
There was a problem hiding this comment.
looks like this commented code can be removed?
There was a problem hiding this comment.
right you are. fixed in bea47fe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some functions of the code in the
datapackage were creating new Kubernetes clients, using them, and passing them elsewhere. This PR makes a few changes to eliminate that pattern:mainfuncjackfan.us.kg/arschles/kubeapp/apipackage, and use thoseThis change allows for unit tests to provide an in-memory implementation to test the behavior of these functions without any externally running services. This change allows us to implement the first bullet point in the description of meta: tests #38:
Contributes to #38