-
Notifications
You must be signed in to change notification settings - Fork 180
docs(monitoring): document grafana and influxdb persistence #713
Conversation
@vdice can you take a look to the updated doc and try to set persistence for grafana and influxdb |
|
||
If you wish to have persistence for Grafana you can set `enabled` to `true` in the `values.yaml` file before running `helm install`. | ||
|
||
* ` grafana:` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting here is odd. It's a bullet point list with embedded code. Can you change it to a code snippet, like so?
grafana:
# Configure the following ONLY if you want persistence for on-cluster grafana
# GCP PDs and EBS volumes are supported only
persistence:
enabled: true
size: 5Gi
|
||
If you wish to have persistence for InfluxDB you can set `enabled` to `true` in the `values.yaml` file before running `helm install`. | ||
|
||
* ` influxdb:` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here with the wonky formatting
|
||
## InfluxDB | ||
|
||
InfluxDB writes data to the host disk, however, if the InfluxDB pod dies and comes back on | ||
another host the data will not be recovered. We intend to fix this in a future release. The InfluxDB Admin UI is also | ||
another host the data will not be recovered, you need to enable on-cluster persistence for data to persist. The InfluxDB Admin UI is also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably better to switch the comma for a period here, as they are two complete sentences.
if the InfluxDB pod dies and comes back on another host, the data will not be recovered. You need to enable on-cluster persistence for data to persist.
|
||
## PVC Dynamic Provisioning | ||
|
||
Kubernetes v1.4.x has introduced Dynamic Provisioning and Storage Classes, you can read about it [here](http://blog.kubernetes.io/2016/10/dynamic-provisioning-and-storage-in-kubernetes.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
V in V1.4.x should be lowercase for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v is lowercase there already
* ` enabled: true # Set to true to enable persistence` | ||
* ` size: 5Gi # PVC size` | ||
|
||
You have to set (if you do not have it already) `standard` StorageClass as per [PVC Dynamic Provisioning](#pvc-dynamic-provisioning), as it does not get set by default in Kubernetes v1.4.x and v1.5.x. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
V in V1.4.x and V1.5.x should be lowercase for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v is lowercase there already
* ` enabled: true # Set to true to enable persistence` | ||
* ` size: 5Gi # PVC size` | ||
|
||
You have to set (if you do not have it already) `standard` StorageClass as per [PVC Dynamic Provisioning](#pvc-dynamic-provisioning), as it does not get set by default in Kubernetes v1.4.x and v1.5.x. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
V in V1.4.x and V1.5.x should be lowercase for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v is lowercase there already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm having a hard time reading today. Sorry
@bacongobbler updated as per your comments |
|
||
Note: AWS and GCE/GKE have different `StorageClass` settings. | ||
|
||
AWS `storage-standard.yaml` manifest: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this should be the GCE/GKE
variant and the one below AWS
...
@vdice good spotting, updated |
No description provided.