Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

docs(tuning-component-settings): elaborate with practical examples #749

Merged
merged 1 commit into from
Mar 7, 2017

Conversation

vdice
Copy link
Member

@vdice vdice commented Mar 2, 2017

@vdice vdice self-assigned this Mar 2, 2017
@vdice vdice requested review from mboersma and bacongobbler March 2, 2017 23:23
@mboersma mboersma added this to the v2.12 milestone Mar 7, 2017
Copy link
Member

@bacongobbler bacongobbler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to also document a third option; one which would be able to be stored in version control:

$ helm fetch deis/workflow --untar
$ $EDITOR workflow/charts/controller/templates/controller-deployment.yaml

Then run helm install ./workflow --namespace deis --name deis to apply the changes, or helm upgrade deis ./workflow if the cluster is already running.

Not a blocker, but while we're at it... :)

@vdice
Copy link
Member Author

vdice commented Mar 7, 2017

Good suggestion @bacongobbler -- updated.

@vdice vdice merged commit 427e49a into deis:master Mar 7, 2017
@vdice vdice deleted the docs/fix-276 branch March 7, 2017 18:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants