chore: update to the main tip of runwasi and libcontainer #138
Conversation
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
There was a problem hiding this comment.
Thanks @Mossaka for putting this change together!
I like where this is going a lot. I think these shims would benefit a lot from the simplified API.
I left a few commends where I think there are opportunities to simplify the code.
In particular:
- I think the executors could be simplified by rewriting how the error handling is done.
- In a few places the code uses
select!with a single branch instead of.await, I'm not sure why. - In
wwsyou could useStdioto redirectstderrinstead of working around it :-)
| if let Some(stdout) = stdout { | ||
| dup(STDOUT_FILENO)?; | ||
| dup2(stdout, STDOUT_FILENO)?; | ||
| fn is_linux_executable(spec: &Spec) -> anyhow::Result<()> { |
There was a problem hiding this comment.
comment: this would be prime candidate for a utils crate ^^
There was a problem hiding this comment.
Should go into the containerd-shim-wasmcrate
There was a problem hiding this comment.
Hopefully with the simplified API we wouldn't need to expose it
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Removed |
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
|
My local integraion tests passed. Hopefully the CI will pass too this time |
|
Umm I am not sure why the slight test still failed... 🥲 |
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
|
Congrats @Mossaka ! |
No description provided.