-
-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix creation of remote control processor #242
Conversation
Thanks @izaera , I need you to rebase the PR so I can merge it. |
Is that enough for merging @deivid-rodriguez? I'm not really sure what happened... I thought I had rebased locally before issuing the PR :-o |
@izaera I like a linear PR rebased on top of master before merging it, so I'd like you to rework (or reopen) this PR to have a single commit. Regarding the build failure, I'm pretty sure it has nothing to do with this change. |
OK. I have pushed -force the rebased commit. I finally discovered what happened: I was rebasing with origin/master instead of upstream/master :-( (that's because we don't use upstream right now at work). |
Thanks @izaera ! :)
Yee, that happens. You're having very bad luck with this PR, lots of problems that are not your fault... Now the Appveyor build is failing... Could you try changing |
I added the workaround myself. You just need to rebase again. |
There you go 👍 |
I'm so sorry for being a pain in the ass, but the current config of the repo is very strict... I still need another rebase for merging. |
Done :-). |
Thanks for your patience! |
\o/
|
Resend of previous pull request changing require_relative to require.