-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop Byebug after continue #80
Conversation
46e303d
to
e9594c1
Compare
We can't pass tests without deivid-rodriguez/byebug#160 in byebug. |
e1a9867
to
0f5bd21
Compare
08ced7f
to
0404e81
Compare
@k0kubun Thre's a couple of extra breaking changes in 7.0.
Hope it helps! |
Thanks for your advice! |
Here you go, rebase and it should be fine! |
Thank you for your quick work! Rebased and Travis CI passed except for Ruby 2.0. |
I see, the error in 2.0 is that same as deivid-rodriguez/byebug#183. The quick way I see of fixing it requires yet another breaking change. Too many breaking changes but I'm not going to think about it too much. Hold on. |
Ok rebase now. |
Rebased and passing all tests now. |
Stop Byebug after continue
Fixes #61
To optimize performance, I want to stop Byebug after exiting Pry's REPL.
This change must be shipped with deivid-rodriguez/byebug#160. So dependency of byebug should be updated after the pull request is merged.
With deivid-rodriguez/byebug#160, this worked fine in my rails application and it became faster.