Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Byebug after continue #80

Merged
merged 3 commits into from
Nov 5, 2015

Conversation

k0kubun
Copy link
Contributor

@k0kubun k0kubun commented Oct 14, 2015

Fixes #61

To optimize performance, I want to stop Byebug after exiting Pry's REPL.
This change must be shipped with deivid-rodriguez/byebug#160. So dependency of byebug should be updated after the pull request is merged.

With deivid-rodriguez/byebug#160, this worked fine in my rails application and it became faster.

@k0kubun k0kubun force-pushed the byebug-stop branch 2 times, most recently from 46e303d to e9594c1 Compare October 14, 2015 09:11
@k0kubun
Copy link
Contributor Author

k0kubun commented Oct 14, 2015

We can't pass tests without deivid-rodriguez/byebug#160 in byebug.

@k0kubun k0kubun force-pushed the byebug-stop branch 2 times, most recently from e1a9867 to 0f5bd21 Compare October 17, 2015 16:15
@k0kubun k0kubun force-pushed the byebug-stop branch 3 times, most recently from 08ced7f to 0404e81 Compare November 5, 2015 14:39
@k0kubun k0kubun mentioned this pull request Nov 5, 2015
@deivid-rodriguez
Copy link
Owner

@k0kubun Thre's a couple of extra breaking changes in 7.0.

  • at_return now receives a parameter which is the return value of the method.
  • When attaching to the debugger, you might need to switch the step_out call and pass 4 steps instead of 3, because returns from c-methods are now taken into account too.

Hope it helps!

@k0kubun
Copy link
Contributor Author

k0kubun commented Nov 5, 2015

Thanks for your advice!

@deivid-rodriguez
Copy link
Owner

Here you go, rebase and it should be fine!

@k0kubun
Copy link
Contributor Author

k0kubun commented Nov 5, 2015

Thank you for your quick work! Rebased and Travis CI passed except for Ruby 2.0.

@deivid-rodriguez
Copy link
Owner

I see, the error in 2.0 is that same as deivid-rodriguez/byebug#183. The quick way I see of fixing it requires yet another breaking change. Too many breaking changes but I'm not going to think about it too much.

Hold on.

@deivid-rodriguez
Copy link
Owner

Ok rebase now.

@k0kubun
Copy link
Contributor Author

k0kubun commented Nov 5, 2015

Rebased and passing all tests now.

deivid-rodriguez pushed a commit that referenced this pull request Nov 5, 2015
Stop Byebug after continue
@deivid-rodriguez deivid-rodriguez merged commit a9c4d4b into deivid-rodriguez:master Nov 5, 2015
@k0kubun k0kubun deleted the byebug-stop branch November 5, 2015 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants