Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploymentMode is not overrided by conf #272

Closed
aureamunoz opened this issue Jul 16, 2019 · 0 comments
Closed

deploymentMode is not overrided by conf #272

aureamunoz opened this issue Jul 16, 2019 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@aureamunoz
Copy link
Collaborator

The deploymentMode element is never override by configuration either in annotation or annotationless mode.
DeploymentMode takes a value (dev) by default but it should be override by specific configuration if present.
Annotiation mode:
@ComponentApplication(name = "hello-world", deploymentMode = DeploymentMode.build, exposeService = true, envs = @Env(name = "key1", value = "val1"))
should generate:

- apiVersion: "devexp.runtime.redhat.com/v1alpha2"
  kind: "Component"
  metadata:
    name: "component-it-issue-71"
  spec:
    deploymentMode: "build"
    exposeService: true
    envs:
    - name: "key1"
      value: "val1"

Annotiationless mode:
application.properties like

dekorate.component.name=annotationless component
dekorate.component.envs[0].name=key_from_properties
dekorate.component.envs[0].value=value_from_properties
dekorate.component.buildType=docker
dekorate.component.deploymentMode=build

should produce:

- apiVersion: "devexp.runtime.redhat.com/v1alpha2"
  kind: "Component"
  metadata:
    labels:
      app: "component-example-annotationless-properties"
      version: "0.7-SNAPSHOT"
      group: "amunozhe"
    name: "component-example-annotationless-properties"
  spec:
    deploymentMode: "build"
    runtime: "spring-boot"
    version: "2.1.0.RELEASE"
    exposeService: false
@aureamunoz aureamunoz added the bug Something isn't working label Jul 16, 2019
@aureamunoz aureamunoz self-assigned this Jul 16, 2019
aureamunoz added a commit to aureamunoz/dekorate that referenced this issue Jul 16, 2019
iocanel pushed a commit that referenced this issue Jul 16, 2019
@aureamunoz aureamunoz added this to the 0.7.6 milestone Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant