Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

component name is not overrided by conf #276

Closed
aureamunoz opened this issue Jul 17, 2019 · 0 comments · Fixed by #281
Closed

component name is not overrided by conf #276

aureamunoz opened this issue Jul 17, 2019 · 0 comments · Fixed by #281
Milestone

Comments

@aureamunoz
Copy link
Collaborator

The name of component is never override by configuration either in annotation or annotationless mode.
name takes always the <artifactId> as value but it should be override by specific configuration if present.
Annotiation mode:
@ComponentApplication(name = "hello-world", deploymentMode = DeploymentMode.build, exposeService = true, envs = @env(name = "key1", value = "val1"))
should generate:

- apiVersion: "devexp.runtime.redhat.com/v1alpha2"
  kind: "Component"
  metadata:
    name: "hello-world"
  spec:
    deploymentMode: "build"
    exposeService: true
    envs:
    - name: "key1"
      value: "val1"

Annotiationless mode:
application.properties like

dekorate.component.name=hello-world
dekorate.component.envs[0].name=key_from_properties
dekorate.component.envs[0].value=value_from_properties
dekorate.component.buildType=docker
dekorate.component.deploymentMode=build

should produce:

- apiVersion: "devexp.runtime.redhat.com/v1alpha2"
  kind: "Component"
  metadata:
    labels:
      app: "component-example-annotationless-properties"
      version: "0.7-SNAPSHOT"
      group: "amunozhe"
    name: "hello-world"
  spec:
    deploymentMode: "build"
    runtime: "spring-boot"
    version: "2.1.0.RELEASE"
    exposeService: false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant