Fix Kind extension to generate manifests #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plus, add the Kind page into the dekorate site. This pull request is related to quarkusio/quarkus#28078
iocanel
requested changes
Oct 5, 2022
There was a problem hiding this comment.
The pull request looks good.
But I think that besides the imagePullPolicy we should also provide a default value to serviceType. More specifically we need to set it by default to NodePort for kind yml/json.
This is something that we already do for minikube/kind in Quarkus and it would be good to keep things aligned.
|
PR updated including the suggested change. |
aureamunoz
reviewed
Oct 5, 2022
|
@aureamunoz PR updated |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus, add the Kind page into the dekorate site.
This pull request is related to quarkusio/quarkus#28078