Fix decorator cycle issue with Cert-Manager and OpenShift #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sgitario
force-pushed
the
add_example_certmanager_ocp
branch
from
f6a2401 to
cc78d42
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sgitario
commented
Apr 19, 2023
| CertificateBuilder builder = new CertificateBuilder(); | ||
|
|
||
| // metadata | ||
| builder.withNewMetadata() | ||
| .withName(getName(meta)) | ||
| .withNamespace(meta.getMetadata().getNamespace()) |
There was a problem hiding this comment.
Updating the namespace was not necessary as there is a decorator that populates all the resources with the correct namespace.
Sgitario
commented
Apr 19, 2023
| @@ -56,27 +58,31 @@ public void generate(CertificateConfig config) { | |||
| LOGGER.info("Processing certificate config."); | |||
| validate(config); | |||
|
|
|||
| String defaultName = configurationRegistry.get(BaseConfig.class).map(BaseConfig::getName) | |||
| .orElse(config.getProject().getBuildInfo().getName()); | |||
| String name = defaultIfEmpty(config.getName(), defaultName); | |||
There was a problem hiding this comment.
This is the important fix: Instead of getting the name from the generated deployment resource, it will get it from the BaseConfig.
I've confirmed that this works fine for the kubernetes and openshift extensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to quarkiverse/quarkus-cert-manager#39 (comment)