Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove js-delegatable-utils dependency on eth-simple-keyring #14

Open
danfinlay opened this issue Dec 14, 2022 · 0 comments
Open

Remove js-delegatable-utils dependency on eth-simple-keyring #14

danfinlay opened this issue Dec 14, 2022 · 0 comments

Comments

@danfinlay
Copy link
Collaborator

eth-simple-keyring depends on ethereumjs-wallet, which depends on the browserify polyfill for crypto, which means none of these modules work in an environment that doesn't polyfill the crypto module. That includes the latest create-react-app, or any lean webpack configuration. Removing that dependency will allow this module to live in leaner and more modern projects.
danfinlay added a commit to delegatable/mobymask-ui that referenced this issue Dec 14, 2022
@danfinlay
Polyfilled crypto
1f01cf4 
This is sad and shouldn't be necessary. delegatable/delegatable-eth#14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danfinlay