Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage to CI #287

Merged
merged 11 commits into from
Aug 6, 2024
Merged

Conversation

zachschuermann
Copy link
Collaborator

@zachschuermann zachschuermann commented Jul 18, 2024

We can leverage LLVM instrumentation-based coverage information via cargo-llvm-cov for code coverage info. The latter has instructions to run locally - this PR introduces a new CI task called coverage to install/run cargo-llvm-cov and upload results to codecov.

based on top of #284

@zachschuermann zachschuermann requested a review from nicklan July 18, 2024 19:56
Copy link
Collaborator

@nicklan nicklan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine. re-request once we get the token sorted so we can just make sure it does the right thing

Copy link

codecov bot commented Aug 6, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@zachschuermann
Copy link
Collaborator Author

okay looks like its (mostly?) working now. have a link to coverage for the last commit here (but nothing to compare against I guess): https://app.codecov.io/github/delta-incubator/delta-kernel-rs/commit/4fe559d2b07563e88b3e8404fde3218f6f83ce08

@zachschuermann zachschuermann merged commit e0a2e5e into delta-io:main Aug 6, 2024
12 checks passed
@zachschuermann zachschuermann deleted the coverage branch August 6, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants