Cleanup tests, run everything (except hdfs) #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicklan
requested review from
zachschuermann
and removed request for
zachschuermann
nicklan
commented
Jul 18, 2024
| @@ -59,7 +59,7 @@ jobs: | |||
| override: true | |||
| - uses: Swatinem/rust-cache@v2 | |||
| - name: test | |||
| run: cargo test --verbose --all-features | |||
| run: cargo test --workspace --verbose --all-features -- --skip read_table_version_hdfs | |||
There was a problem hiding this comment.
the hdfs test starts up a java environment which takes >1m and makes the whole test suite take much longer, so I'm skipping it for now (could become a nightly test)
There was a problem hiding this comment.
created #285 to track
zachschuermann
approved these changes
Jul 18, 2024
| @@ -59,7 +59,7 @@ jobs: | |||
| override: true | |||
| - uses: Swatinem/rust-cache@v2 | |||
| - name: test | |||
| run: cargo test --verbose --all-features | |||
| run: cargo test --workspace --verbose --all-features -- --skip read_table_version_hdfs | |||
There was a problem hiding this comment.
created #285 to track
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure our CI runs all the tests for the whole workspace.
Also fix some failing tests in
ffidue to either mistakes in the doc comment or slight compiler output changes.