Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: list log files with checkpoint when version is None #312

Merged
merged 5 commits into from
Aug 14, 2024
Merged

fix: list log files with checkpoint when version is None #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c17e9be
match delta-rs to avoid an error
mervynhang Aug 9, 2024
1c00a36
Update kernel/src/snapshot.rs
mervynzhang Aug 9, 2024
d486cef
skip_test, v2 checkpoint not supported
mervynhang Aug 13, 2024
5a144a3
remove old comment
mervynhang Aug 13, 2024
f417837
Merge branch 'main' into main
zachschuermann Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions kernel/src/snapshot.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,9 @@ impl Snapshot {
// List relevant files from log
let (mut commit_files, checkpoint_files) =
match (read_last_checkpoint(fs_client.as_ref(), &log_url)?, version) {
(Some(cp), None) => {
list_log_files_with_checkpoint(&cp, fs_client.as_ref(), &log_url)?
}
(Some(cp), Some(version)) if cp.version >= version => {
list_log_files_with_checkpoint(&cp, fs_client.as_ref(), &log_url)?
}
Expand Down
4 changes: 2 additions & 2 deletions kernel/tests/golden_tables.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,8 +408,8 @@ golden_test!("time-travel-start", latest_snapshot_test);
golden_test!("time-travel-start-start20", latest_snapshot_test);
golden_test!("time-travel-start-start20-start40", latest_snapshot_test);

golden_test!("v2-checkpoint-json", latest_snapshot_test); // passing without v2 checkpoint support
golden_test!("v2-checkpoint-parquet", latest_snapshot_test); // passing without v2 checkpoint support
skip_test!("v2-checkpoint-json": "v2 checkpoint not supported");
skip_test!("v2-checkpoint-parquet": "v2 checkpoint not supported");

// BUG:
// - AddFile: 'file:/some/unqualified/absolute/path'
Expand Down
Loading