Skip to content

Commit

Permalink
feat: make find_files public (#1560)
Browse files Browse the repository at this point in the history
# Description
Make the find_files API public, same as public API for connectors'
[`markFilesAsRead`](https://delta-io.github.io/connectors/latest/delta-standalone/api/java/io/delta/standalone/OptimisticTransaction.html#markFilesAsRead-io.delta.standalone.expressions.Expression-):


# Related Issue(s)
<!---
For example:

- 
--->

closes #1559

# Documentation

<!---
Share links to useful documentation
--->

---------

Co-authored-by: Will Jones <[email protected]>
  • Loading branch information
yjshen and wjones127 authored Jul 27, 2023
1 parent 6a77efb commit 012ca7f
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions rust/src/delta_datafusion.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1085,7 +1085,9 @@ impl TreeNodeVisitor for FindFilesExprProperties {
}
}

pub(crate) struct FindFiles {
/// Representing the result of the [find_files] function.
pub struct FindFiles {
/// A list of `Add` objects that match the given predicate
pub candidates: Vec<Add>,
/// Was a physical read to the datastore required to determine the candidates
pub partition_scan: bool,
Expand Down Expand Up @@ -1289,7 +1291,8 @@ pub(crate) async fn scan_memory_table(
join_batches_with_add_actions(batches, map)
}

pub(crate) async fn find_files<'a>(
/// Finds files in a snapshot that match the provided predicate.
pub async fn find_files<'a>(
snapshot: &DeltaTableState,
object_store: ObjectStoreRef,
schema: Arc<ArrowSchema>,
Expand Down

0 comments on commit 012ca7f

Please sign in to comment.