chore: enable RUF ruleset for ruff (#2677)

# Description This PR proposes to enable the [`RUF`](https://docs.astral.sh/ruff/rules/#ruff-specific-rules-ruf) ruleset. ``` ruff check . ``` returned: ``` warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`: - 'ignore' -> 'lint.ignore' - 'select' -> 'lint.select' - 'isort' -> 'lint.isort' deltalake/table.py:52:26: RUF100 [*] Unused `noqa` directive (unused: `F811`) deltalake/writer.py:63:26: RUF100 [*] Unused `noqa` directive (unused: `F811`) tests/pyspark_integration/test_write_to_pyspark.py:109:37: RUF010 [*] Use explicit conversion flag Found 3 errors. [*] 3 fixable with the `--fix` option. ``` So these were simply fixed with `ruff check . --fix`. #2673 handles the fixing of the outdated config. --------- Co-authored-by: R. Tyler Croy <[email protected]>
delta-io · Jul 18, 2024 · ab977e3 · ab977e3
1 parent 640ee6e
commit ab977e3
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/python/deltalake/table.py b/python/deltalake/table.py
@@ -49,7 +49,7 @@
 from deltalake.schema import Schema as DeltaSchema
 
 try:
-    import pandas as pd  # noqa: F811
+    import pandas as pd
 except ModuleNotFoundError:
     _has_pandas = False
 else:

diff --git a/python/deltalake/writer.py b/python/deltalake/writer.py
@@ -61,7 +61,7 @@
 )
 
 try:
-    import pandas as pd  # noqa: F811
+    import pandas as pd
 except ModuleNotFoundError:
     _has_pandas = False
 else:

diff --git a/python/pyproject.toml b/python/pyproject.toml
@@ -83,7 +83,9 @@ select = [
     # pyflakes
     "F",
     # isort
-    "I"
+    "I",
+    # ruff-specific rules
+    "RUF"
 ]
 ignore = ["E501"]
 

diff --git a/python/tests/pyspark_integration/test_write_to_pyspark.py b/python/tests/pyspark_integration/test_write_to_pyspark.py
@@ -106,7 +106,7 @@ def test_checks_min_writer_version(tmp_path: pathlib.Path):
     )
 
     # Add a constraint upgrades the minWriterProtocol
-    spark.sql(f"ALTER TABLE delta.`{str(tmp_path)}` ADD CONSTRAINT x CHECK (c1 > 2)")
+    spark.sql(f"ALTER TABLE delta.`{tmp_path!s}` ADD CONSTRAINT x CHECK (c1 > 2)")
 
     with pytest.raises(
         DeltaProtocolError, match="This table's min_writer_version is 3, but"
-Original file line number
+Diff line change
@@ Expand Up / @@ -83,7 +83,9 @@ select = [ @@
         # pyflakes
         "F",
         # isort
-        "I"
+        "I",
+        # ruff-specific rules
+        "RUF"
     ]
     ignore = ["E501"]
@@ Expand Down @@