feat: merge schema by using record batch writer #2232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
binding/python
|
Closing, since RecordBatchWriter seems to be older than writer.rs. I guess the better way would be replacing RecordBatchWriter, but this is a public Rust API, so probably not easy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a counter proposal to my own PR here: #2229
The Idea is mainly to get completely rid of writer.rs and use RecordBatchWriter instead. I can hardly tell much about the side-effects, but so far it compiles :)
Related Issue(s)
Fixes #1386 (once completed, which it is NOT)
Documentation