Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generated columns [WIP] #3123

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ion-elgreco
Copy link
Collaborator

@ion-elgreco ion-elgreco commented Jan 12, 2025

Description

Adds generated columns.

Related Issue(s)

TODO

  • add rust/python tests
  • add column generation to MERGE
  • Add tests for improved protocol setting based on schema (timestampntz, invariants, generated columns)
  • Verify whether generated columns can only be added during creation, and not during schema evolution or add columns :S

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Jan 12, 2025
@ion-elgreco ion-elgreco force-pushed the feat/generated-columns branch 2 times, most recently from be67624 to e3f55b7 Compare January 12, 2025 16:47
@ion-elgreco ion-elgreco changed the title feat: generated columns feat: generated columns [WIP] Jan 12, 2025
@ion-elgreco ion-elgreco force-pushed the feat/generated-columns branch from 6efe64b to 18a3db8 Compare January 12, 2025 18:49
@rtyler rtyler marked this pull request as draft January 12, 2025 18:52
@ion-elgreco ion-elgreco force-pushed the feat/generated-columns branch from bce9720 to 4378bd9 Compare January 12, 2025 19:22
@ion-elgreco ion-elgreco force-pushed the feat/generated-columns branch from 4378bd9 to 173659c Compare January 12, 2025 19:22
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 57.05706% with 143 lines in your changes missing coverage. Please review.

Project coverage is 72.15%. Comparing base (1521a08) to head (5db1970).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/operations/write.rs 32.92% 51 Missing and 4 partials ⚠️
crates/core/src/operations/merge/mod.rs 53.84% 30 Missing and 12 partials ⚠️
crates/core/src/operations/add_column.rs 0.00% 16 Missing ⚠️
crates/core/src/kernel/models/actions.rs 83.58% 3 Missing and 8 partials ⚠️
crates/core/src/table/mod.rs 50.00% 9 Missing ⚠️
crates/core/src/kernel/models/schema.rs 68.18% 4 Missing and 3 partials ⚠️
crates/core/src/delta_datafusion/mod.rs 81.81% 1 Missing and 1 partial ⚠️
crates/core/src/operations/create.rs 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3123      +/-   ##
==========================================
- Coverage   72.25%   72.15%   -0.10%     
==========================================
  Files         134      134              
  Lines       42973    43175     +202     
  Branches    42973    43175     +202     
==========================================
+ Hits        31050    31155     +105     
- Misses       9929    10010      +81     
- Partials     1994     2010      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated Columns
1 participant