Introduce row ID write table feature and table property #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottsand-db
approved these changes
Apr 20, 2023
core/src/main/scala/org/apache/spark/sql/delta/DeltaConfig.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/sql/delta/sources/DeltaSQLConf.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/org/apache/spark/sql/delta/rowid/RowIdSuite.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds knobs to enable Row IDs when creating a new Delta table, as defined in the Row ID specification (#1610):
rowIds: Require writers to support row IDs. Used to enable row IDs on newly created tables.rowIds.enabled: Indicate whether all rows have an assigned row ID.rowIds.allowForDevOnly: restrict the use of Row IDs to testing for now.How was this patch tested?
Adding test suite RowIdSuite:
Does this PR introduce any user-facing changes?
No, an internal configuration
rowIds.allowForDevOnlyis introduced to hide the partial row ID implementation during development. The flag is enabled in tests only.