[Spark] Relax type check in SchemaUtils.normalizeColumnNamesInDataType
#4143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c27kwan
approved these changes
Feb 11, 2025
ala
changed the title
SchemaUtils. normalizeColumnNamesInDataTypeSchemaUtils.normalizeColumnNamesInDataType
c27kwan
approved these changes
Feb 12, 2025
ala
force-pushed
the
permissive_type_check
branch
from
682f931 to
39c79ef
Compare
|
actually, maybe we can leave out the whitespace for another time. :) |
ala
force-pushed
the
permissive_type_check
branch
from
cfd1f75 to
11e11c3
Compare
|
All right. Back to the original minimal change then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This PR modifies the nested filed name normalization code. This code is used when we write to a Delta table. It makes sure that the names of all the columns in the source data (meaning, the data that we are writing to the table) match the target table column names in terms of case. For example, if the source contains column
address.CITY, while the table contains columnaddress.city, the source column is renamed to match the table.If the schema of the source data and the table data differs enough to interfere with the name normalization, we log
delta.assertions.schemaNormalization.nonNestedTypeMismatch. However, this check is too restrictive, and as a result, we log this assertion too often. This PR relaxes the check. We now assume that any two atomic columns can be matched to each other.How was this patch tested?
New tests in
SchemaUtilsSuite.Does this PR introduce any user-facing changes?
No.