[Kernel] [Cleanup] Move SnapshotManager::checkpoint to Checkpointer class
#4147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottsand-db
commented
Feb 11, 2025
| /** The name of the last checkpoint file */ | ||
| public static final String LAST_CHECKPOINT_FILE_NAME = "_last_checkpoint"; | ||
|
|
||
| public static void checkpoint(Engine engine, Clock clock, SnapshotImpl snapshot) |
There was a problem hiding this comment.
nearly a verbatim copy. no logic change. i change the inputs (snapshot instead of version), define tablePath and logPath and version variables, and make some minor logger improvements.
scottsand-db
commented
Feb 11, 2025
| @@ -602,10 +533,7 @@ private Optional<Long> getStartCheckpointVersion(Engine engine, Optional<Long> v | |||
| }); | |||
| }) | |||
| .orElseGet( | |||
| () -> { | |||
| logger.info("Loading last checkpoint from the _last_checkpoint file"); | |||
There was a problem hiding this comment.
The invoker of a method should only log additional context that the invokee would not know about.
In this case, the invokee should be responsible for printing this.
huan233usc
approved these changes
Feb 12, 2025
vkorukanti
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This PR moves
SnapshotManager::checkpointtoCheckpointerclass. This reduces coupling and increases cohesion.I also tidy up some code and logger statements along the way.
How was this patch tested?
Just a refactor. Existing UTs.
Does this PR introduce any user-facing changes?
No.