[Kernel] Minor cleanup of APIs used for checking read/write supported protocol #4149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkorukanti
force-pushed
the
tfRefactor1
branch
from
391a717 to
b6a4ac7
Compare
allisonport-db
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, we pass optional
MetadatatovalidateReadSupportedTable, which is just used for checking whether it has supported column mapping mode. We don't need to check that as if an unknown mode is passed, it will anyway fail later on. Also if a new mode is added, it will be part of a new table featureAlso for
validateWriteSupportedTable, we pass theschemaandmetadataseparately. Instead just passing themetadata(which has theschema) should be sufficient.The implementation of these APIs going to change in the subsequent PRs.
How was this patch tested?
Existing tests.