[Spark] Pass catalog table through TahoeLogFileIndex #4150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctring
force-pushed
the
cuong-nguyen_data/catalog-table-tahoe-index
branch
from
9297a52 to
b0ca9d5
Compare
ctring
force-pushed
the
cuong-nguyen_data/catalog-table-tahoe-index
branch
from
b0ca9d5 to
1e273b9
Compare
| @@ -181,6 +182,12 @@ object DeltaTestImplicits { | |||
| def snapshot: Snapshot = deltaTable.initialSnapshot | |||
| } | |||
|
|
|||
| implicit class TahoeLogFileIndexObjectTestHelper(index: TahoeLogFileIndex.type) { | |||
| def apply(spark: SparkSession, deltaLog: DeltaLog): TahoeLogFileIndex = { | |||
There was a problem hiding this comment.
Are there existing tests which uses the 2 arg constructor?
There was a problem hiding this comment.
Yes. There are quite a few in these files:
prakharjain09
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
TahoeLogFileIndexcontainsDeltaLog::updatecalls but it does not pass in the catalog table yet. This causes the check for catalog table existence unreliable inDeltaLog::update. This PR fixes that by adding the catalog table argument toTahoeLogFileIndexand pass the catalog table fromDeltaLog::createRelationHow was this patch tested?
Run existing unit tests
Does this PR introduce any user-facing changes?
No