Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spark] Simplify reference binding in DeltaInvariantChecker #4209

Merged

Conversation

tomvanbussel
Copy link
Collaborator

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

This PR simplifies the binding of attribute references in DeltaInvariantCheckerExec. Before this PR we had some code to manually bind these references. This PR changes this to make Spark do the binding for us.

How was this patch tested?

Existing tests.

Does this PR introduce any user-facing changes?

@tomvanbussel tomvanbussel requested a review from johanl-db March 3, 2025 10:23
Copy link
Collaborator

@johanl-db johanl-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor looks good overall, can you point at existing tests in the PR description?

@vkorukanti vkorukanti merged commit 08f3a79 into delta-io:master Mar 3, 2025
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants